Conversation
Summary of ChangesHello @CybotTM, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the documentation for reStructuredText image and figure handling by introducing a new section that explains and demonstrates floating and alignment capabilities. It provides users with clear guidance on how to position images and figures within text flow using both CSS classes and the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds comprehensive documentation for the new image and figure floating and alignment features. The new section is well-structured, with clear explanations and useful examples. My feedback focuses on improving the consistency of formatting for code literals within the reStructuredText file to ensure correct rendering and maintainability.
There was a problem hiding this comment.
Pull request overview
This PR documents the new image and figure floating and alignment feature that will be available in render-guides version 0.37.0. The documentation provides comprehensive guidance on how to use CSS float classes and the :align: option to position images alongside text.
Changes:
- Added
:class:and:align:parameters to the optional parameters list with cross-references to the new section - Created a comprehensive "Image and figure floating and alignment" section covering CSS classes, align option, clearing floats, and responsive behavior
- Added three working examples (Examples 8-10) demonstrating figure float-left, figure align-right, and image float-left with shadow
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Add documentation for the new CSS float and alignment support for images and figures introduced in render-guides 0.37.0. Split the monolithic Images.rst into three focused pages: - Images.rst: basics, parameters, Examples 1-2 - ImageZoom.rst: zoom modes, options, accessibility, Examples 3-7 - ImageAlignment.rst: float/align, clearing, responsive, Examples 8-10 Depends on: TYPO3-Documentation/render-guides#1174
5752e02 to
d9f27c3
Compare
Summary
:class:and:align:to the optional parameters list with cross-referencesfloat-left/float-right),:align:option, clearing floats (rst-class:: clear-both), and responsive behaviorContext
The render-guides 0.37.0 release will add CSS float/alignment support for images and figures. This PR adds the corresponding user documentation.
Test plan
:ref:image-float-alignment) resolve from the parameters list